Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health test to check for multiple switches that have VFP extension enabled #393

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add health test to check for multiple switches that have VFP extension enabled #393

wants to merge 2 commits into from

Conversation

arudell
Copy link
Member

@arudell arudell commented Feb 20, 2025 •
edited
Loading

Description

Summary of changes:

  • Added a new health test to check if multiple VMSwitches have the VFP extension enabled.

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

@arudell arudell linked an issue Feb 20, 2025 that may be closed by this pull request
[Debug] Add test to check if multiple vmswitches have VFP enabled #392
Open
@arudell arudell added the enhancement New feature or request label Feb 20, 2025
@arudell arudell self-assigned this Feb 20, 2025
@arudell arudell changed the title [Debug] Add health test to check for multiple switches that have VFP extension enabled Add health test to check for multiple switches that have VFP extension enabled Feb 20, 2025
@arudell arudell marked this pull request as ready for review February 20, 2025 18:59
@arudell arudell requested a review from a team as a code owner February 20, 2025 18:59
@arudell arudell enabled auto-merge February 20, 2025 18:59
sbgms
sbgms reviewed Feb 21, 2025
View reviewed changes
src/modules/SdnDiag.Health.psm1
$i = 0

try {
$vmSwitches = Get-VMSwitch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a generic utility method and invoke that to see the results ? This way the fucntionality can be accessed more broadly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ANd we could expose that into the psd1 too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbgms can you clarify more? Are you wanting something that returns back a PSObject?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbgms sbgms sbgms left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@arudell arudell

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Debug] Add test to check if multiple vmswitches have VFP enabled
2 participants
@arudell @sbgms